Problem with publishing port

[Khazrak]

After successfully exposing a port (thanks to the fix for #48 ) I'm now trying to publish that port.
The CreateRequest looks like this (which is wrong):
PortBindings={1337=[PortBinding(HostIp=0.0.0.0, HostPort=1337, additionalProperties={})]}

I attached the simple code example that generated this request:

Simple.txt

[iocanel]

@Khazrak: The only issue that I see (with naked eye) is the key of the map which should be "1337/tcp" instead. However, this is something created by the sample code and not by the client.

Do I miss something?

[Khazrak]

What it should look like:
"PortBindings": {"container_port/tcp": [{"HostIp": "host_ip", "HostPort": "host_port"}]}
ex
"PortBindings": {"1337/tcp": [{"HostIp": "0.0.0.0", "HostPort": "1337"}]}

what it looks like now
PortBindings={1337=[PortBinding(HostIp=0.0.0.0, HostPort=1337, additionalProperties={})]}

All the ports should be in String's here

[iocanel]

@Khazrak: They are Strings :-)

The JSON object looks like this:

"PortBindings":{"1337/tcp":[{"HostIp":"0.0.0.0","HostPort":"1337"}]}

How did u generate the output? Let me create a quick unit test for that.

[iocanel]

unit test added.

[Khazrak]

Ok, now got it to work. Needed to add the "/tcp" manually to the key-part of the Map. Would be nice with a builder for it (the PortBinding has a builder, but not for the Map<String,ArrayList<PortBindning>>)

[iocanel]

Even if we had a builder for the map itself (which is on my radar), that would still wouldn't solve the problem, as we would need to have a custom logic:

if map key does not match <port/protocol> use tcp as a default protocol

This is something I wouldn't want to have inside the builder.

I am wondering though if the client could use some sort of filters to apply modifications on the outgoing JSON before we send it. A filter would be a place were we could host some logic like this.

[iocanel]

I think that the cleanest way to prevent this is by using validation.