-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for incremental Gradle builds #150
Comments
in #118 I had envisioned this to be:
but based on above I'll probably instead make it:
#118 also mentions:
but I now realized that would require to |
@vorburger hey, just a quick note: I'm at Red Hat and jump onto the s2i images at the beginning of next week. sorry for the delay ... |
Once the base #118 (#121) is in, I'll follow-up on it to add support for
--incremental
Gradle builds.I'll have to find a way to make Gradle write everything we want to preserve into
${S2I_ARTIFACTS_DIR}/gradle
, which I've already used in the final clean-up commit of #121 forGRADLE_CLEAR_REPO
.We'll then also have to make
java/templates/s2i/save-artifacts
include that in the TAR (how, together with m2?), and I'm guessing somewhere "restore" it - @rhuss where does that happen?I can then test this with the new
test.sh
(just manually unfortunately; I don't see how to reasonably easily automatically cover this...) and observe that the 2nd incremental Gradle run is not re-downloading anymore, and that the 2nd Maven incremental run still not re-downloading (as it currently, just to verify non-regression).The text was updated successfully, but these errors were encountered: