-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[On-HOLD] feat: Ignore vulnerability feature for VA #817
base: master
Are you sure you want to change the base?
[On-HOLD] feat: Ignore vulnerability feature for VA #817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 79.33% 79.19% -0.14%
==========================================
Files 21 21
Lines 1679 1692 +13
==========================================
+ Hits 1332 1340 +8
- Misses 347 352 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix tests.
@jparsai Do we really need this for VA? VA is very specific for clair. |
@rafiu007 Dont we want to ignore in Clair? |
I cant think of a use case where we would like to ignore. By default clair serves all packages |
Okay, for now we can keep this PR open, later if Clair requires ignore feature we can take this PR in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it On-Hold as Clair may not need this feature yet.
Ignore vulnerability feature for VA with test cases