From 3afdd1c769a84b1017bbd4a02fef0dbd1d7033ab Mon Sep 17 00:00:00 2001 From: Reese Williams Date: Wed, 21 Feb 2024 19:46:27 +0000 Subject: [PATCH] Remove my hack --- .github/workflows/preview-release.yaml | 13 +++---------- script/make_release | 2 +- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/.github/workflows/preview-release.yaml b/.github/workflows/preview-release.yaml index 3eaa5b19..6db59f79 100644 --- a/.github/workflows/preview-release.yaml +++ b/.github/workflows/preview-release.yaml @@ -6,7 +6,7 @@ on: - completed push: # Run only on trunk pushes that aren't a new tag release - branches: [trunk] + branches: [trunk, fix-aarch-builds] tags-ignore: "*" env: @@ -64,16 +64,13 @@ jobs: override: true profile: minimal target: aarch64-unknown-linux-gnu - - uses: actions/cache@v2 - with: - path: | - librubyfmt/ruby_checkout - key: ${{ runner.os }}-${{matrix.target}}-ruby-v1-${{ hashFiles('.git/modules/librubyfmt/ruby_checkout/HEAD') }} - if: runner.os == 'macOS' run: | brew install automake bison echo "/usr/local/opt/bison/bin:$PATH" >> $GITHUB_PATH - run: ./script/make_release + env: + TARGET: ${{ matrix.target }} - uses: actions/upload-artifact@v3 with: name: rubyfmt-release-artifact-${{ matrix.os }}-${{ matrix.target }} @@ -109,10 +106,6 @@ jobs: - uses: actions/download-artifact@v3 with: name: rubyfmt-release-artifact-ubuntu-20.04-aarch64-unknown-linux-gnu - - run: | - # The arch part of this path is set with uname, but we cross-compile the arm build on - # an x86 machine, so we want to make sure the name is correct for the release - mv rubyfmt-${{ steps.get-latest-tag.outputs.tag }}-Linux-x86_64.tar.gz rubyfmt-${{ steps.get-latest-tag.outputs.tag }}-Linux-aarch64.tar.gz - uses: actions/download-artifact@v3 with: name: rubyfmt-release-artifact-ubuntu-20.04-native diff --git a/script/make_release b/script/make_release index 9234bfb7..2ac41ef8 100755 --- a/script/make_release +++ b/script/make_release @@ -44,7 +44,7 @@ case "$target" in TARGET_AR=aarch64-linux-gnu-ar \ cargo build --release --target aarch64-unknown-linux-gnu - cargo_target_dir_prefix="aarch64-unknown-linux-gnu" + cargo_target_dir_prefix="aarch64-unknown-linux-gnu/" # This is kind of a hack, since we're assuming we're on a Linux host. release_tarball_os="Linux" release_tarball_arch="aarch64"