Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check before unmounting #38

Open
vincenzo opened this issue Nov 21, 2015 · 4 comments
Open

Check before unmounting #38

vincenzo opened this issue Nov 21, 2015 · 4 comments

Comments

@vincenzo
Copy link

The plugin's default behaviour is to unmount the target before mounting it, just in case it was mounted already.

However, un-mounting when it's not mounted results in an error on the screen (nothing major, but annoying when part of a clean vagrant output)

umount: /Users/vincenzo/Documents/Repositories/solas: not currently mounted

Checking for the mount rather doing umount/mount has also the benefit of less overhead.

I am just not versed at all in Ruby, else I'd make a PR...
I can even manage to identify the piece of code and write what I think it's the fix, but I am really just not sure how to go about testing it then...

@vincenzo
Copy link
Author

I decided to take the changes upon myself.
However, I see quietness on this project and I wonder if you are going to be around to merge a pull request, @fabiokr? Else, I'll just fork your project.

@fabiokr
Copy link
Owner

fabiokr commented Nov 26, 2015

I'm not using the plugin myself anymore, but I can help with it if you provide a PR.

@vincenzo
Copy link
Author

Ok, that's all I need. Thanks @fabiokr.

@istr
Copy link

istr commented Dec 17, 2015

I'm not using the plugin myself anymore, but I can help with it if you provide a PR.

Just out of curiosity: what kind of file system sharing host <-> guest (with good performance) do you use instead now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants