-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check before unmounting #38
Comments
I decided to take the changes upon myself. |
I'm not using the plugin myself anymore, but I can help with it if you provide a PR. |
Ok, that's all I need. Thanks @fabiokr. |
Just out of curiosity: what kind of file system sharing host <-> guest (with good performance) do you use instead now? |
The plugin's default behaviour is to unmount the target before mounting it, just in case it was mounted already.
However, un-mounting when it's not mounted results in an error on the screen (nothing major, but annoying when part of a clean vagrant output)
Checking for the mount rather doing umount/mount has also the benefit of less overhead.
I am just not versed at all in Ruby, else I'd make a PR...
I can even manage to identify the piece of code and write what I think it's the fix, but I am really just not sure how to go about testing it then...
The text was updated successfully, but these errors were encountered: