Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F3D: Update help text for new types #2044

Merged
merged 8 commits into from
Mar 7, 2025

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Mar 5, 2025

  • Parse camera-view-up as a direction
  • Update direction related integration testing
  • Update help text for direction and factor
  • Update doc for direction and factor
  • Add conversion from direction_t to vector3_t
  • Remove C++11 related point3 and vector3 constructor

@mwestphal mwestphal requested a review from Meakk March 5, 2025 08:49
Copy link

github-actions bot commented Mar 5, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (c7f7a99) to head (09ea5f4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   95.80%   95.79%   -0.02%     
==========================================
  Files         128      128              
  Lines       10488    10481       -7     
==========================================
- Hits        10048    10040       -8     
- Misses        440      441       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal requested a review from snoyer March 5, 2025 12:23
@mwestphal mwestphal requested a review from Meakk March 6, 2025 06:47
@mwestphal mwestphal merged commit ac73b83 into f3d-app:master Mar 7, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants