Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "color" option type #1762

Closed
mwestphal opened this issue Dec 6, 2024 · 3 comments
Closed

Add "color" option type #1762

mwestphal opened this issue Dec 6, 2024 · 3 comments
Assignees
Labels
help wanted Please help with this issue! source:libf3d
Milestone

Comments

@mwestphal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
See #1570

F3D support many option with different option types, it would be beneficial to support a new "color" option type instead of relying on double vector. A color should obviously be stored in a double_vector of size 3.

Describe the solution you'd like

  • Add it to types.h with the correct API
  • Add a naive parse/format methods to options_tools.h.in
  • Use it for at least one option in options.json
  • Add testing in TestSDKOptions*
@salfakir
Copy link

salfakir commented Dec 6, 2024

Thanks for creating this issue

@mwestphal mwestphal added the help wanted Please help with this issue! label Dec 19, 2024
@mwestphal mwestphal added this to the 3.1.0 milestone Dec 19, 2024
@mwestphal
Copy link
Contributor Author

Hi @salfakir , Ill take over this issue if thats alrigth with you.

@mwestphal mwestphal assigned mwestphal and unassigned salfakir Jan 28, 2025
@mwestphal
Copy link
Contributor Author

Added in #1967

@github-project-automation github-project-automation bot moved this to Done in F3D Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Please help with this issue! source:libf3d
Projects
Status: Done
Development

No branches or pull requests

2 participants