Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--output with multiple file groups could create multiple png outputs #10

Open
mwestphal opened this issue Nov 12, 2021 · 7 comments
Open
Labels
type:enhancement New feature or request

Comments

@mwestphal
Copy link
Contributor

mwestphal commented Nov 12, 2021

Context
F3D supports opening multiple file groups and saving png outputs, lets bring these features together in order to be able to save multiple images when opening multiple file groups

Suggested solution
When opening multiple file groups, rely on filename templating to write different files.

eg :

f3d ./files/* --output=output_{model}.png

Could create output_model1.png, output_model2.png ..

@mwestphal mwestphal added type:enhancement New feature or request Priority:P2 labels Nov 12, 2021
@mwestphal mwestphal added this to the 1.3.0 milestone Nov 12, 2021
@mwestphal
Copy link
Contributor Author

@Meakk
Copy link
Member

Meakk commented Jan 17, 2022

I think it's out of scope, one can just do:

for f in ./files/*; do
    f3d $f --output=output_$f.png
done

@mwestphal
Copy link
Contributor Author

Still, current behavior is not super nice:

f3d ./files/* --output=output.png output a screenshot of the first file.

@mwestphal mwestphal removed this from the 1.3.0 milestone Aug 14, 2022
@mwestphal mwestphal mentioned this issue Feb 5, 2023
2 tasks
@mwestphal mwestphal added the help wanted Please help with this issue! label Jan 7, 2024
@mwestphal
Copy link
Contributor Author

mwestphal commented Jan 20, 2024

@Meakk @snoyer I'm thinking of closing this. nobody ever requested it and I think #46 is more important anyway. What do you think ?

@mwestphal mwestphal added workflow:discussion and removed help wanted Please help with this issue! labels Jan 20, 2024
@mwestphal
Copy link
Contributor Author

Need #653 to move forward

@snoyer
Copy link
Contributor

snoyer commented Jan 20, 2024

I think --output should just warn if there's model files that haven't used in the render.

However if you really want multiple outputs you could use a templating mechanism as proposed in #1194 so that f3d a.gltf b.gltf --output={model}.png generates a.glft.png and b.gltf.png

@mwestphal
Copy link
Contributor Author

related to #46

@mwestphal mwestphal changed the title "--output" with multiple files could create multiple png outputs --output with multiple file groups could create multiple png outputs Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

3 participants