Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opposite merge flag meaning for Batch.Set and Transaction.Set method in Android Wrapper #98

Open
weinamdev opened this issue Dec 1, 2021 · 1 comment

Comments

@weinamdev
Copy link

Hi there,

I found the merge flag for Set method in both Transaction and Batch in Android wrapper carry opposite meaning as compared to Document.SetAsync, which is consistent with Firebase official documentations.

However, Batch.Set and Transaction.Set in iOS wrapper working fine, and performing consistently with Document.SetAsync definition.

Expected Behavior: When Merge = true, only replace the affected fields

Actual Behavior: In Android Wrapper, Merge flag in batch write and transaction works in opposite way, hence when Merge = false only replaces affected field, and Merge = true replace the entire document

Thank you.

@ccgould
Copy link

ccgould commented Aug 24, 2023

Surprised this hasn't been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants