[#1] 멀티 모듈 구조 작업 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
requested changes
Nov 13, 2024
|
방금 확인했는데요. 모든 서브 모듈에 gradlew랑 settings.gradle이 존재하네요. 이 부분을 지우시면 될 것 같습니다. 그리고 이 부분이 어떤 역할을 하는지 고민해 보시면 좋을 것 같네요. :-) |
Closed
|
리뷰 감사합니다 😁 말씀해주신 내용 모두 반영하여 우아한 기술블로그 - 멀티모듈 설계 이야기 with Spring, Gradle 을 참고하여 아래와 같이 구성해보았습니다.
|
f-lab-lyan
reviewed
Nov 14, 2024
| @@ -0,0 +1,3 @@ | |||
| rootProject.name = 'beautify-project' | |||
| include ':bp-app-api', ':bp-app-batch', ':bp-core-web', ':bp-dto', ':bp-dto', | |||
There was a problem hiding this comment.
Suggested change
| include ':bp-app-api', ':bp-app-batch', ':bp-core-web', ':bp-dto', ':bp-dto', | |
| include 'bp-app-api', 'bp-app-batch', 'bp-core-web', ':bp-dto', ':bp-dto', |
f-lab-lyan
reviewed
Nov 14, 2024
.gitignore
Outdated
There was a problem hiding this comment.
필요없는 내용은 일단 빼면 좋을 것 같습니다.
f-lab-lyan
reviewed
Nov 14, 2024
| @@ -0,0 +1,3 @@ | |||
| rootProject.name = 'beautify-project' | |||
| include ':bp-app-api', ':bp-app-batch', ':bp-core-web', ':bp-dto', ':bp-dto', | |||
| ':bp-kafka-event-publisher', ':bp-utils', ':bp-domain-rdb' | |||
f-lab-lyan
reviewed
Nov 14, 2024
build.gradle
Outdated
| @@ -0,0 +1,51 @@ | |||
| plugins { | |||
| id 'java' | |||
| id 'org.springframework.boot' version '3.3.5' | |||
There was a problem hiding this comment.
Suggested change
| id 'org.springframework.boot' version '3.3.5' | |
| id 'org.springframework.boot' version '3.3.5' apply false |
|
6주차 멘토링(2024-11-14)에서 말씀해주신 내용 모두 반영하였습니다! 😅 |
f-lab-lyan
approved these changes
Nov 18, 2024
|
고생하셨습니다. :-) 편하실 때, 머지 하시죠! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
멀티 모듈 구조 작업 중 아래와 같이 빌드가 되지 않는 이슈가 있습니다.
위 슬랙 내용중 빌드가 되지 않는 모듈은(a 모듈)
bp-app-batch입니다.