Codecov Report

Merging #76 (893855d) into master (33742b8) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   92.22%   92.01%   -0.22%     
==========================================
  Files           5        5              
  Lines         579      576       -3     
==========================================
- Hits          534      530       -4     
- Misses         45       46       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33742b8...893855d. Read the comment docs.

Codecov is failed for some reason

Not sure what is that about. 3 lines or so lost coverage but it doesn't seem very relevant. Unless the Nuxt reload triggers during testing and somehow messes with coverage but then I would expect a lot more misses.

Also note that this fix is not ideal as changes in imports that the controllers depend on won't trigger reload thus those won't be reflected. But it's still somewhat of an improvement for DX.

Not sure what is that about. 3 lines or so lost coverage but it doesn't seem very relevant. Unless the Nuxt reload triggers during testing and somehow messes with coverage but then I would expect a lot more misses.

Also note that this fix is not ideal as changes in imports that the controllers depend on won't trigger reload thus those won't be reflected. But it's still somewhat of an improvement for DX.

You want to merge it anyway? I can bypass the checks failing and still merge. Let me know

I'm a bit on the fence. It semi-fixes the issue. Ideally it should be fixed completely but I'm not sure how. I think the imports would have to be static for it to work automatically but that means that those would have to be pre-generated before Nuxt is started or something...

I'm fine with not merging this or leaving it open until I have more time to investigate.

@pi0 suggested that we talk about solving this for Nitro but not sure in what form the discussion should be.
Also, I'd really would like to improve this for Nuxt 2 since it might be a while until I can use Nitro (just tried today and it's still problematic for various reasons).