(exa PR) 1190: Fix device major minor numbers

[cafkafk]

ogham/exa#1190

[cafkafk]

Considering libc defines pub type c_uint = u32;, I don't see the reason for using i64, would this ever be negative? https://docs.rs/libc/latest/libc/type.c_uint.html

[cafkafk]

this might be to make space for this difference:

# Linux
pub type dev_t = u64;
pub fn major(dev: ::dev_t) -> ::c_uint;
pub fn minor(dev: ::dev_t) -> ::c_uint;

# macOS
pub type dev_t = i32;
pub fn major(dev: dev_t) -> i32;
pub fn minor(dev: dev_t) -> i32;

ogham/exa#1126 (comment)

[SteveLauC]

would this ever be negative?

For glibc, I guess it won't be.

Ref: how to interpret the dev_t type

[cafkafk]

would this ever be negative?

For glibc, I guess it won't be.

Ref: how to interpret the dev_t type

I guess the original intent might have been to have space enough for both pub fn major(dev: dev_t) -> i32; and pub fn major(dev: ::dev_t) -> ::c_uint; (u32)?

[cafkafk]

This was super helpful to understand what's going on for future reference: ogham/exa#1126 (comment)

[cafkafk]

In order to progress on this we'd need feedback from someone with an apple box

[SteveLauC]

In order to progress on this we'd need feedback from someone with an apple box

For macOS, I am not sure if the major can be negative, but the minor won't be, see:

https://github.com/rust-lang/libc/blob/28ab9b9e7bd04a5c5aca3f4d78583214f63d4002/src/unix/bsd/apple/mod.rs#L5186-L5196

[cafkafk]

For potential testers:

cargo run --release -- -l /dev/ > changes.txt; exa -l /dev/ > old.txt; diff changes.txt old.txt;

[cafkafk]

I found an apple laptop to test this on:

error[E0308]: mismatched types
--> src/fs/file.rs:366:39
|
366 | major: unsafe { major(device_ids) as i64 },
| ----- ^^^^^^^^^^ expected i32, found u64
| |
| arguments to this function are incorrect
|
note: function defined here
--> /Users/ces/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.147/src/unix/bsd/apple/mod.rs:5186:12
|
5186 | pub fn major(dev: dev_t) -> i32 {
| ^^^^^
help: you can convert a u64 to an i32 and panic if the converted value doesn't fit
|
366 | major: unsafe { major(device_ids.try_into().unwrap()) as i64 },
| ++++++++++++++++++++

error[E0308]: mismatched types
--> src/fs/file.rs:367:39
|
367 | minor: unsafe { minor(device_ids) as i64 },
| ----- ^^^^^^^^^^ expected i32, found u64
| |
| arguments to this function are incorrect
|
note: function defined here
--> /Users/ces/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.147/src/unix/bsd/apple/mod.rs:5190:12
|
5190 | pub fn minor(dev: dev_t) -> i32 {
| ^^^^^
help: you can convert a u64 to an i32 and panic if the converted value doesn't fit
|
367 | minor: unsafe { minor(device_ids.try_into().unwrap()) as i64 },
| ++++++++++++++++++++

For more information about this error, try rustc --explain E0308.
error: could not compile eza (bin "eza") due to 2 previous errors

[cafkafk]

This needs an apple user to work on these changes.

[github-actions]

This pull request is stale because it has been open for 30 days with no activity.

[github-actions]

This pull request was closed because it has been inactive for 14 days since being marked as stale.