Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add json icon for .jsonc #1166

Closed
Blubberland opened this issue Sep 29, 2024 · 2 comments
Closed

feat: Add json icon for .jsonc #1166

Blubberland opened this issue Sep 29, 2024 · 2 comments

Comments

@Blubberland
Copy link

It looks like there the only thing to be done is to add this line

    "jsonc"    => Icons::JSON,             // 

to this entity

const EXTENSION_ICONS: Map<&'static str, char> = phf_map!

Not sure if this is correct. I'm not a developer.
I don't feel comfortable going through this whole pull-request procedure and it seems to be a bit much just for an icon.

@cafkafk
Copy link
Member

cafkafk commented Sep 29, 2024

I don't feel comfortable going through this whole pull-request procedure and it seems to be a bit much just for an icon.

People are working on a configuration file that is more user facing, but it's a best effort thing.

@Blubberland
Copy link
Author

I could find #139 and #897 which would - in case an agreed solution will be found - would solve this issue.
Seems like it would take some more time to do that. I'm not able to help unfortunatetly, but grateful for the work that's put into it.
Looking forward to a config file!

Thanks!

@Blubberland Blubberland closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants