Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /bin/sh instead of /bin/bash if possible in scripts #10

Open
emanuelb opened this issue Apr 6, 2021 · 1 comment
Open

Use /bin/sh instead of /bin/bash if possible in scripts #10

emanuelb opened this issue Apr 6, 2021 · 1 comment

Comments

@emanuelb
Copy link

emanuelb commented Apr 6, 2021

There are many scripts in repo that use #!/bin/bash for some of them it's possible to use #!/bin/sh instead without other modifications, for example like in ./eznode/tor/install ./eznode/tor/bin/tor-newnym

it might worth to change it for some other scripts as well if they not relaying to much on bash specific operations (see checkbashisms tool)

@shesek
Copy link
Contributor

shesek commented Apr 14, 2021

As we discussed elsewhere, I don't see a compelling advantage for adapting some of the scripts to use sh, given that the scripts are running in a predictable container environment, don't require portability, and that bash is relied upon heavily and is going to be installed either way.

I'm open to accepting a PR for the scripts that already work with sh as-is and just need their shebang changed, but also okay keeping them with bash for uniformity sake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants