Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for leftwm theme.ron #11

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

VuiMuich
Copy link
Contributor

@VuiMuich VuiMuich commented Oct 26, 2022

As suggested in PyWal #688 here is a template for creating a theme.ron.
It was tested a couple of weeks ago with original pywal, except the background_color which is a new feature that is expected to become merged by the end of the week.
@arcolinux could you give this another test spin?

Edit: also worth noting, the background_color will go unseen in almost any use cases, but I thought it might make sense to style all available color fields.

@eylles
Copy link
Owner

eylles commented Oct 26, 2022

i can merge it to master right now, but if you want i can wait until @arcolinux @arcolinuxz reports back from the test you know for sanity's sake.

@arcolinuxz
Copy link

arcolinuxz commented Oct 26, 2022

I let someone else test it. Just added the one file in my /usr....
My first attempt was not working.
I have no time to retest it soon.
At the soonest in 10 days or so

@eylles
Copy link
Owner

eylles commented Oct 28, 2022

welp, will hold onto pushing the release of pywal16 until sunday to give this some days and look for anything else that may need to be cleaned up before releasing, if this template has not been tested by then i will just merge it and any problem that appears can be addressed in a late bugfix release.

@eylles eylles merged commit ecc4c93 into eylles:master Oct 30, 2022
@eylles
Copy link
Owner

eylles commented Oct 30, 2022

into master this goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants