Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip on Fix 387 - add "system" color support for SVG parser #535

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Conversation

mgoldin
Copy link
Contributor

@mgoldin mgoldin commented Feb 28, 2019

screenshot 2019-02-28 at 18 05 02

screenshot 2019-02-28 at 18 03 53

@mgoldin mgoldin requested a review from ystrot February 28, 2019 11:09
@ystrot ystrot self-assigned this Mar 18, 2019
Copy link
Member

@ystrot ystrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few comments. Once they will be addressed, you may add a test case and I'll merge it.

@@ -595,7 +595,7 @@ open class SVGParser {
let red = CGFloat((rgbValue >> 16) & 0xff)
let green = CGFloat((rgbValue >> 08) & 0xff)
let blue = CGFloat((rgbValue >> 00) & 0xff)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you don't use SwiftLint. Please install it to make sure there is no formatting issues.

Source/svg/SVGParser.swift Show resolved Hide resolved
@ystrot ystrot added this to the 0.9.5 milestone Mar 18, 2019
@ystrot ystrot modified the milestones: 0.9.5, 0.9.6 Apr 4, 2019
@ystrot ystrot self-requested a review April 8, 2019 09:56
@ystrot ystrot merged commit 9a1abcc into master Apr 8, 2019
@ystrot ystrot deleted the fix/387 branch April 8, 2019 09:58
@ystrot ystrot modified the milestones: 0.9.6, 0.9.7 Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants