-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Carthage support #520
Conversation
Hi, can this get merged? |
Hi Dmitry, Sorry for delay. Macaw team are not using Carthage, so it needs a bit more time to check this. We'll try to merge it on the next week. |
Hi, @DmitryPR, can you explain in little details, what wrong with automatical fetching by Carthage? For me everyting work as expected in current setup. |
Hello, the integrators who are using Macaw with Carthage need to supply github "Exyte/Macaw" ~> 0.9.3 and github "drmohundro/SWXMLHash" == 4.7.5 Because Macaw uses this dependency This is incorrect behaviour as all the dependencies that Macaw rely on should be listed in the Cartfile so that when the integrators specify github "Exyte/Macaw" ~> 0.9.3 the SWXMLHash would be downloaded along with Macaw |
So here is the setup: We have an iOS library which has Macaw as a dependency using Cocoapods where the SWXMLHash is specified as dynamic dependency After our library is integrated into another project it requires dynamic libraries to be loaded along side with our iOS library: Here we have to define SWXMLHash as a Carthage dependency because Macaw brings this dependency in This PR makes sure that when there is no need to manually add as it should be listed in your repository in Carthage file |
@DmitryPR, I checked, you are right, thank you for your work! One more moment, can you change equality in dependency == to ~>, please. As soon you change this, PR will be merged. |
Dependenices for the libraries used in the project should be list in the Cartfile so when an integrator adds Macaw to his Cartfile the dependencies should be also downloaded
34c232b
to
b03940b
Compare
For some reason the Cartfile was missing so when adding this library using Carthage the SWXMLhash dependency did not get downloaded