Add swift version to podspec #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define swift_version for the Podfile which is read when the library is integrated If this is not supplied then Macaw in Pods settings of the integrated project gets the project's swift version which leads to a problem if the integrator is using different Swift version in his project For him the only workaround is to specify the post_install hook where he sets the config.build_settings['SWIFT_VERSION'] = '4.2' CocoaPods/CocoaPods#7327 For library developers who rely on this library this is also the problem because the s.pod_target_xcconfig is ignored when using the cocoapods-packager CocoaPods/cocoapods-packager#210
|
Hi Dmitry, Thanks for PR, we'll try to fix it as you suggested. |
|
Can this be pod pushed as a version to the cocoapods repo as a new version please? |
|
@robertbarclay sure, once we finish with the recent tasks we will publish a new version. I think it will be done in the nearest 2 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define swift_version for the Podfile which is read when the library is
integrated
If this is not supplied then Macaw in Pods settings of the integrated
project gets the project's swift version which leads to a problem
if the integrator is using different Swift version in his project
For him the only workaround is to specify the post_install hook
where he sets the config.build_settings['SWIFT_VERSION'] = '4.2'
CocoaPods/CocoaPods#7327
For library developers who rely on this library this is also the problem
because the s.pod_target_xcconfig is ignored when using the cocoapods-packager
CocoaPods/cocoapods-packager#210