Fix #502: Finding the tap location inside a group #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ystrot
requested changes
Nov 9, 2018
| public struct TouchPoint { | ||
| public let id: Int | ||
| public let location: Point | ||
| @available(*, deprecated) public let location: Point // absolute location | ||
| private let absoluteLocation: Point |
There was a problem hiding this comment.
Let's avoid this variable in favor of location or make location computable to avoid storing unnecessary variable.
Source/render/GroupRenderer.swift
Outdated
| @@ -51,14 +51,14 @@ class GroupRenderer: NodeRenderer { | |||
| return nil | |||
| } | |||
|
|
|||
| override func doFindAllNodesAt(location: CGPoint, ctx: CGContext) -> [Node]? { | |||
| override func doFindAllNodesAt(location: CGPoint, ctx: CGContext) -> [NodeTouch]? { | |||
There was a problem hiding this comment.
It's too complicated. Let's use following class:
class NodePath {
let node: Node
let location: CGPoint
let parent: NodePath?
}Also do we still need doFindNodeAt method? Can we have only one method to find node by location?
ystrot
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.