Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better named release asserts #1593

Closed
dclong opened this issue Mar 9, 2023 · 4 comments
Closed

Better named release asserts #1593

dclong opened this issue Mar 9, 2023 · 4 comments

Comments

@dclong
Copy link

dclong commented Mar 9, 2023

Is your feature request related to a problem? Please describe.
The naming of release asserts is confusing. For example, it's not obvious whether gitui-linux-musl.tar.gz, gitui-mac.tar.gz and gitui-win.tar.gz are for x86_64 or arm64.

Describe the solution you'd like
Follow a strict naming convention, e.g., gitui-os-arch.tar.gz. For Linux OS, musl, gnu or unknown can be included.

Additional context
Apps might want to download gitui automatically depending on OS and Arch. A strict naming make this much easier to do.

@extrawurst
Copy link
Owner

Good point, feel free to create a PR

@magical-heyrovsky
Copy link

For everyone else confused by this, the "musl" (what even is this?) binary is apparently for x86_64/amd64.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Dec 15, 2023
@extrawurst extrawurst added this to the v0.26 milestone Feb 27, 2024
@stale stale bot removed the dormant Marked by stale bot on close label Feb 27, 2024
@extrawurst
Copy link
Owner

superceded by #2148

@extrawurst extrawurst removed this from the v0.26 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants