This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Fixes naming convention permission check for data items with path attribute. #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permission checking code is currently ignoring the
path
attributes when evaluating. This results in permission checks for secrets defined like this:with the error message
ERROR, not allowed to fetch secret: test/test: key name undefined does not match naming convention ^dev/team-a/.*
.This PR adds handling of the
path
attribute in the permissions check.