Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat: restart watcher if no events seen for specified period #532

Merged

Conversation

Flydiverny
Copy link
Member

@Flydiverny Flydiverny commented Nov 1, 2020

alternative to #531
To see if that can solve #362

A build of this PR is available on docker hub:

flydiverny/kubernetes-external-secrets:6.0.0-with.pr532.27286e0

image:
  repository: flydiverny/kubernetes-external-secrets
  tag: 6.0.0-with.pr532.27286e0

Todo

  • Configurable restart timeout

@2mf
Copy link

2mf commented Nov 9, 2020

This would PR would help me a lot

@Flydiverny Flydiverny marked this pull request as ready for review November 12, 2020 20:06
@Flydiverny Flydiverny merged commit bb1ed9e into external-secrets:master Dec 22, 2020
@Flydiverny Flydiverny deleted the timeout-restart-watch branch December 22, 2020 02:34
@Flydiverny Flydiverny mentioned this pull request Dec 22, 2020
@sparky005
Copy link

Does this resolve #399 as well?

@Flydiverny
Copy link
Member Author

@sparky005 I dont think so

@azzy123
Copy link

azzy123 commented Oct 24, 2021

@Flydiverny I'm still facing this issue where the kes operator hangs randomly after a certain time period. I'm using the updated KES deployment(version 8.3.2) and have configured POLLER_INTERVAL_MILLISECONDS: 100000 and
WATCH_TIMEOUT: 600000. I believe this same issue was rectified previously. Is there any other parameter that we have to configure in the helm values?

@Darius-Ndubi
Copy link

Hi @Flydiverny, I am having this issue . POLLER_INTERVAL_MILLISECONDS: 30000 and WATCH_TIMEOUT: 60000 on KES version: 8.3.2. Polling fails with error ERROR, Error: connect ETIMEDOUT. Is there another way to force the watcher to restart?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants