Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

feat: add e2e test for naming conventions enforcement #412

Conversation

nbendafi-yseop
Copy link
Contributor

Add e2e to test that permitted-key-name prevents ExternalSecret from accessing keys if regex doesn't match key's path

  CRD
    ✓ ensure CRD is managed correctly
    ✓ should reject invalid ExternalSecret manifests

  secretsmanager
    ✓ should pull existing secret from secretsmanager and create a secret with its values (2247ms)                                                                   
    ✓ should pull TLS secret from secretsmanager (134ms)
    permitted annotation
      assuming role
        ✓ should not pull from secretsmanager (3435ms)
      enforcing naming convention
        ✓ should not pull from secretsmanager (3427ms)

  ssm
    ✓ should pull existing secret from ssm and create a secret from it (130ms)
    permitted annotation
      ✓ should not pull from ssm (3427ms)


  8 passing (13s)

PS: should not pull from secretsmanager test is just nested under assuming role describe, while its content is unchanged, by this PR

This PR needs #411 for tests to pass

@nabilbendafi nabilbendafi force-pushed the feature/e2e-test_permitted-key-name branch from aa41af9 to 843b7e9 Compare June 21, 2020 16:20
Copy link
Member

@Flydiverny Flydiverny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the contribution!

@Flydiverny Flydiverny merged commit bfb5ed2 into external-secrets:master Jun 22, 2020
@nbendafi-yseop nbendafi-yseop deleted the feature/e2e-test_permitted-key-name branch June 22, 2020 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants