This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Support mounting existing secrets as files #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently mounting the vault ca cert using this method. The only piece I'd add is that I had to add the |
|
That's what I'm using it for as well; but I left the env var side out of this PR as there's already support for it on the Helm templating side. This keeps the PR generic enough to be used for any other files as needed, and enables this use-case 👍 |
Flydiverny
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
not sure if the version should be changed other than that all good,
@keweilu ?
|
We should not change the chart version in the PR. Once the PR is merged, we can release a new chart to include the changes. |
|
Just released a new chart version which should include those changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I just realised we need to support mounting a CA file as a secret in this pod to communicate with Vault, which is best done through secrets.
This PR therefore copies the
envVarsFromSecretconstruct, but for files.I also bumped the chart version, but I'm not sure that's the correct way of doing things - please let me know if I need to do it differently!