-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't save the global setting #187
Comments
I test it without old table, I have the same issue, don't save the setting. I'll try to debug it. |
In the newer versions all component settings stored in #__extensions table. Yes, try to debug. Turn on Joomla logging and php logs. As one step in debug try to disable |
This afternoon I had time to debug for a while. I don't know why, but in \administrator\components\com_jcomments\models\settings.php line57 read the params of component:
And the $params load previous value of "author_homepage":"0", when in the params in the extension, this field is "author_homepage":"1". After reading for a few minutes it's right. Any cache? No idea I test it with:
The result is the same. I hadn't seen before that a getParams would return the previous value instead of the saved one. I'll keep investigating because I need this to be stable. Very strange. |
I will look at this issue when I have free time. But I strongly recommend to use Joomla com_config. |
Did you check database for errors and repair with standard Joomla tools? |
Yes, nothing, all's right, any errors. |
I have installed last Jcomments v.4.0.33 in Joomla 5.1.4 with php 8.2 and with old Jcomments tables (the old Jcomments v.3.x was uninstalled with migration to J5 but the Jcomments tables weren't deleted).
[BE] Go to JComments - Settings - Layout - Comment from and change these fields:
When I save the setting, I don't have any error and the setting doesn't save and have the default setting.
Does the Jcomments 4.x installer script migrate the old Jcomments tables, so that the old comments aren't lost, or should I assume that the old comments will be removed and I need to delete the old tables?"
The text was updated successfully, but these errors were encountered: