document "trust proxy" settings

[dougwilson]

No description provided.

[crandmck]

This implies that http://expressjs.com/guide.html#proxies is no longer accurate, or at least incomplete. Is that true?

[crandmck]

Just found #152 which has pertinent discussion. Was the usage in the final comment what was actually implemented?

[dougwilson]

This implies that http://expressjs.com/guide.html#proxies is no longer accurate, or at least incomplete. Is that true?

Correct, it is incomplete. app.enable('trust proxy') still works, but of course it doesn't explain how bad it is to do that if you don't understand how your proxy it actually setup (like in a hosting provider like AWS) or talks about all the different settings and how to set it up correctly with them.

Was the usage in the final comment what was actually implemented?

I think so, but I can't say 100%; I'd have to look at the code.

[dougwilson]

example of why this needs documentation: expressjs/express#2307

[hacksparrow]

Documented - http://expressjs.com/4x/api.html#app-settings

[mohamedmohsin]

i enable trust proxy [ app.enable('trust proxy')],but my req.ips is an empty array

[dougwilson]

@mohamedmohsin I'm 99% sure the reason is because you are accessing req.ips after the request has already completed (probably after you already responded to the request). At that point, Node.js no longer provides an IP address for the request, so req.ips will always be empty. If you need to continue this discussion, please submit an issue at https://github.com/strongloop/express/issues/new , send a message to the Express mailing group (https://groups.google.com/group/express-js), or hop on IRC (#express on freenode.net). This is just an issue for making the documentation for the API.