-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #5786
[email protected] #5786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to include changes in the History.md
?
Yeah we do, that said longer term I really want to get us on a tool to automate this. Release Please ideally. We don't even need to auto publish, but just generating the changelog and opening the PR would be awesome. EDIT: I will update that when we get the CI working again and are ready to merge. |
I think that since we plan on fixing up the CI in separate PRs I don't want to let this sit and have to update the branch again for such a small change which is guaranteed to land. Also, just pushed an update for the history. |
This updates
send@^1.0.0
.The failure in CI is expected until we land #5595 because send dropped node versions. It looks like we explicitly break <6 with this.