Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.set() JSON style #3997

Closed
knoxcard opened this issue Jul 1, 2019 · 4 comments · May be fixed by #4044
Closed

app.set() JSON style #3997

knoxcard opened this issue Jul 1, 2019 · 4 comments · May be fixed by #4044

Comments

@knoxcard
Copy link

knoxcard commented Jul 1, 2019

Why cant I do this?

app.set({
  'view engine': 'hbs',
  'colors': require('chalk'),
  'functions': require('./lib/functions')(app)
})

instead of doing this?

app.set('view engine', 'hbs')
app.set('colors', require('chalk'))
app.set('functions', require('./lib/functions')(app))
@wesleytodd
Copy link
Member

See #3218, #3714 & https://github.com/wesleytodd/store-settings

I think this would be a good addition to that module, then could land in either 5 or 6. I feel like there was another discussion about this, but I could not find it. If I were you I would submit a pr to add that on that repo so when we merge those pr's we will just get the new functionality.

@knoxcard
Copy link
Author

knoxcard commented Jul 1, 2019

@dougwilson

@ahmedHusseinF
Copy link

I am new to open source, and this looks like an easy feature, so I will try to submit a pr for this.

@davidmashe
Copy link

one related PR is closed, other is stale. Closing issue, can re-open if PR gets activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants