-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update working session link #283
base: master
Are you sure you want to change the base?
Conversation
What's the intent here? Does the TC link take you to a different zoom meeting? |
Fix the link for the working session, as the links are different for the TC meeting and the working session. |
Although maybe there is an option in |
Ah good to know. Maintaining two nearly identical templates for a single link difference isn't ideal here. We can update the pkgjs action to accept some data via options to pass in. That's a new feature to add. Opened an Issue there to discuss pkgjs/meet#206 |
A hack for now could be to check the issue title in the agenda template to determine if it's TC or Working session, and choose the link to use based on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another workaround, for our specific case, would be to check the title in the template. Im pretty sure it gets passed into the template as a title
We can check that to differentiate between the two types of meetings inside the ejs template and pick a meeting link that way.
@jonchurch That's a very good idea, I'll try it later. |
1015c29
to
bd1eba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt check the time changes, but I assume these are reflective of the correct times or they wouldn't have been updated? Should we update the comment above? Is this because it is not taking into account DST?
Yes, the time change is to reflect the correct time, which is now one hour later, just like it was before #253. |
bd1eba5
to
350eba5
Compare
I've created a PR to add the option and avoid implementing the proposed hack see: pkgjs/meet#207 |
No description provided.