Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite mode utilizing cloned slides #328

Closed
tandcsurf opened this issue Jan 8, 2021 · 7 comments
Closed

Infinite mode utilizing cloned slides #328

tandcsurf opened this issue Jan 8, 2021 · 7 comments
Labels
stale Issues that became stale

Comments

@tandcsurf
Copy link

Describe the feature you'd like:

Additional/alternate version of infinite mode that clones slides, allowing for a center-mode carousel that (like slick or other carousels) will consistently show slides to left/right of current active slide.

Suggested implementation:

Describe alternatives you've considered:

Creating a CSS-driven implementation of center-mode has worked pretty well, but a lack of cloned slides on pure-react-carousel's infinite mode will display a lot of dead space on the left of the first slide.

Teachability, Documentation, Adoption, Migration Strategy:

Flipping a property like "infiniteCloned={true}" on the CarouselProvider would be ideal.

@tim-steele
Copy link
Contributor

@tandcsurf would you be willing to do a pull request with this feature? If you want to do a draft pull request first we would be able to review it.

@RyanPaiva56
Copy link

@tandcsurf are you aware of any way to do this that doesn't cause the carousel to re-render? Cloning slides would still run into the issue that I had here:

#330

@stale
Copy link

stale bot commented Mar 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that became stale label Mar 10, 2021
@nathanharper
Copy link

Bump! I would also really like this. Any movement?

@stale stale bot removed the stale Issues that became stale label Mar 24, 2021
@dkadrios
Copy link

double bump! This is final piece that's keeping me from ditching react-slick

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that became stale label Jun 11, 2021
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically closed becuase it has not had recent activity.

@stale stale bot closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that became stale
Projects
None yet
Development

No branches or pull requests

5 participants