Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes #252
Automatically pause "autoplay" (
isPlaying
) when the user changes slides using one of these HOC control components:<ButtonNext />
<ButtonBack />
<ButtonFirst />
<ButtonLast />
<Dot />
This mirrors the existing behavior where autoplay is paused when the user interacts with the Slider (i.e. drags on mobile).
Why:
Currently, the isPlaying interval timer doesn't reset when the user visits a slide using one of these buttons. The end result (as defined in #252) is that a user could progress to a slide and then immediately be progressed to another slide. I don't see why the user would EVER want this to happen.
How:
Set
isPlaying: false
in the CarouselProvider state in the onClick handler for each of the aforementioned HOCs.Checklist:
I meant to create a
bugfix/*
branch in my repo to merge in but accidentally committed to Master instead; NBD.