Traits with object values are not serialised correctly

[pwfcurry]

I'm trying to pass a "company" trait - map of values - to Expo.Segment.identify(..., traits).

In our android app, the "company" object is sent as a string of the JSON instead of a Map.

The offending method is here:
https://github.com/expo/expo-analytics-segment/blob/master/android/src/main/java/expo/modules/analytics/segment/SegmentModule.java#L60

Example raw payload:

{
  "traits": {
    "company": "{\"id\":\"abc123\", ...
    ...
}

"company" is defined as an object here: https://segment.com/docs/spec/identify/

This is handled correctly in iOS:

  "traits": {
    "company": {
      "id": "abc123",

Interestingly com.segment.analytics.Traits does not have any mention of company.

[sjchmiela]

Thank you for the issue submission! I think I fixed it in expo/expo#2517, you'll be able to test the fix yourself in the upcoming SDK 31. 🙂