-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-14180][eas-cli] rename with-as-environment-variables-set eas update flag to environment #2692
[ENG-14180][eas-cli] rename with-as-environment-variables-set eas update flag to environment #2692
Conversation
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Subscribed to pull request
Generated by CodeMention |
Size Change: -1.41 kB (0%) Total Size: 52.9 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2692 +/- ##
=======================================
Coverage 52.94% 52.94%
=======================================
Files 576 576
Lines 22105 22105
Branches 4337 4337
=======================================
Hits 11701 11701
Misses 10370 10370
Partials 34 34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this name!
Why
During dogfooding it came out that this flag is too long and confusing
How
Just use
environment
Test Plan
Tests, types