Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-14180][eas-cli] rename with-as-environment-variables-set eas update flag to environment #2692

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 14, 2024

Why

During dogfooding it came out that this flag is too long and confusing

How

Just use environment

Test Plan

Tests, types

Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review November 14, 2024 22:42
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela
packages/eas-cli/src/commands/update/** @EvanBacon, @byCedric, @wschurman

Generated by CodeMention

Copy link

Size Change: -1.41 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -1.41 kB (0%)

compressed-size-action

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.94%. Comparing base (df13e04) to head (a0b4bf2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2692   +/-   ##
=======================================
  Coverage   52.94%   52.94%           
=======================================
  Files         576      576           
  Lines       22105    22105           
  Branches     4337     4337           
=======================================
  Hits        11701    11701           
  Misses      10370    10370           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic changed the title [eas-cli] rename with-as-environment-variables-set eas update flag to environment [ENG-14180][eas-cli] rename with-as-environment-variables-set eas update flag to environment Nov 14, 2024
Copy link
Member

@jonsamp jonsamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this name!

@szdziedzic szdziedzic merged commit 26fd7a7 into main Nov 15, 2024
11 of 12 checks passed
@szdziedzic szdziedzic deleted the 11-14-_eas-cli_rename_with-as-environment-variables-set_eas_update_flag_to_environment branch November 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants