From 6743abab8a5be299bfbf18f346b7ce7c0cd14b3c Mon Sep 17 00:00:00 2001 From: Will Schurman Date: Wed, 24 Apr 2024 16:47:52 -0700 Subject: [PATCH 1/2] [eas-cli] Fill in min expo-updates version for expo-updates CLI --- packages/eas-cli/src/project/projectUtils.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/eas-cli/src/project/projectUtils.ts b/packages/eas-cli/src/project/projectUtils.ts index 83998e6ef8..a6b3800a42 100644 --- a/packages/eas-cli/src/project/projectUtils.ts +++ b/packages/eas-cli/src/project/projectUtils.ts @@ -165,8 +165,8 @@ export async function isModernExpoUpdatesCLIWithRuntimeVersionCommandSupportedAs return true; } - // TODO(wschurman): add semver check once we know the SDK51 version of expo-updates that supports this - return false; + // Anything SDK 51 or greater uses the expo-updates CLI + return semver.gte(expoUpdatesPackageVersion, '0.25.4'); } export async function installExpoUpdatesAsync( From 3d1c5c481fa7d8b2e5f5e3adcd07f55f9d12fc42 Mon Sep 17 00:00:00 2001 From: Will Schurman Date: Thu, 25 Apr 2024 16:17:15 +0000 Subject: [PATCH 2/2] update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cc310aadf..cfdad529bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ This is the log of notable changes to EAS CLI and related packages. ### 🧹 Chores +- Fill in min expo-updates version for expo-updates CLI. ([#2344](https://github.com/expo/eas-cli/pull/2344) by [@wschurman](https://github.com/wschurman)) + ## [7.8.4](https://github.com/expo/eas-cli/releases/tag/v7.8.4) - 2024-04-24 ### 🧹 Chores