Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better separation of configurations and values #32

Closed
bpiwowar opened this issue Feb 23, 2023 · 1 comment
Closed

Better separation of configurations and values #32

bpiwowar opened this issue Feb 23, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request ideas Ideas to discuss/think about
Milestone

Comments

@bpiwowar
Copy link
Collaborator

bpiwowar commented Feb 23, 2023

In some cases, it is better to distinguish configurations from instances - e.g. when using deriving from torch.nn.Module. In those cases, it would be better to have an explicit split between both.

class A(Config):
    x: Param[int]

@A.instance()
class InstanceA(A):
   def __post_init__(self): 
       pass

class B(A):
    y: Param[int]

@B.instance()
class BInstance(B, A.XPMValue):
    pass
@bpiwowar bpiwowar added the enhancement New feature or request label Feb 23, 2023
@bpiwowar bpiwowar added this to the First stable release milestone Feb 23, 2023
@bpiwowar bpiwowar self-assigned this Feb 23, 2023
@bpiwowar bpiwowar added the ideas Ideas to discuss/think about label Jul 18, 2023
@bpiwowar bpiwowar modified the milestones: Version 1.0.0, 1.1.0 Jul 23, 2023
@bpiwowar bpiwowar changed the title New configuration/task layout Ability to have specific values Jan 25, 2024
@bpiwowar bpiwowar changed the title Ability to have specific values Better separation of configurations and values Jan 25, 2024
@bpiwowar
Copy link
Collaborator Author

bpiwowar commented Feb 6, 2024

Fixed in 90ffc04

@bpiwowar bpiwowar closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ideas Ideas to discuss/think about
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant