Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: Posterior Predictive Checks in docs #192

Closed
grburgess opened this issue May 20, 2021 · 1 comment · Fixed by #200
Closed

JOSS Review: Posterior Predictive Checks in docs #192

grburgess opened this issue May 20, 2021 · 1 comment · Fixed by #200
Assignees
Labels
documentation Missing docs or mistakes in existing ones enhancement New feature or request joss Issues related to JOSS review

Comments

@grburgess
Copy link

The docs are very thorough! I think one thing that could be added that could help improve model checking in general is showing posterior predictive checks against some of the data to give an impression of over / under prediction of the data given the model and the likelihood.

For example:

https://gallery.exoplanet.codes/en/latest/tutorials/tess/

Here one could simulate future data from the conditioned model given the variability in the data to see if the posterior is, e.g. inflating the uncertainty in the data.

This is a stylistic choice, but has a lot of opportunity to teach the community as this is a a widely used tool.

Here is an example of what I mean:
image

@grburgess grburgess added the enhancement New feature or request label May 20, 2021
@grburgess
Copy link
Author

linking: openjournals/joss-reviews#3285

@dfm dfm added documentation Missing docs or mistakes in existing ones joss Issues related to JOSS review labels May 20, 2021
@dfm dfm self-assigned this May 20, 2021
@dfm dfm closed this as completed in #200 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Missing docs or mistakes in existing ones enhancement New feature or request joss Issues related to JOSS review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants