Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imports and warning quashing less opaque #18

Closed
dfm opened this issue May 17, 2021 · 0 comments · Fixed by #21
Closed

Make imports and warning quashing less opaque #18

dfm opened this issue May 17, 2021 · 0 comments · Fixed by #21
Labels
joss Issues related to JOSS review

Comments

@dfm
Copy link
Member

dfm commented May 17, 2021

Ref: openjournals/joss-reviews#3285 (comment)

Just a note - check they all import matplotlib.pyplot as plt somewhere at the top? A couple of these don't and I needed to add this line. Perhaps the GitHub actions are importing this already?

and

There are many warnings: perhaps in the interests of a reader hoping to clone code there could be a warnings filter placed at the top. For example, I get a lot of (and this may be to do with my Python environment)...

Currently there is a hidden cell that sets up plotting and squashes these warnings. There's not much we can do about these warnings since they're a deeper pymc/theano issue, but we should at least make it clear that we're doing what we're doing. I do also currently import matplotlib in that cell so in some cases it might be hiding the previous issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joss Issues related to JOSS review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant