-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nucleotide-codons: deprecate in favour of protein-translation #532
Conversation
If I look at other deprecated exercises, they almost all start with "NOTE: This exercise has been deprecated.". I like that this is the first thing you see in that case, which makes it really clear that the exercise is deprecated. Perhaps we can do that here too? |
Let's try that, then. Since you didn't object to linking the issue nor the suggestion of what exercise to implement instead, I kept them, of course, just added the necessary line |
Someone needs to remind me what this .deprecated file does again, whether this PR needs to be dependent on exercism/rust#258. Okay far as I can tell from exercism/DEPRECATED.x-api#140 , deprecating it globally just prevents it from showing up in the "to be implemented" section of any other track, so I don't think exercism/rust#258 and this PR need to be temporally dependent on each other in some way. |
I think linking to the issue and the suggestion are great features, so I'm glad you kept them in. That means this PR can be merged, right? |
I'm ready for it to happen, and I think it is safe even while the Rust PR hasn't been merged. If we are unsure at all, we better let @kytrinyx know before the daily site deploy, in case it does cause any unexpected effects. |
@kytrinyx would merging this PR would be safe to do? |
Yes, this is safe to merge. |
In the exercism.io issue: [Deprecate the SETUP.md file in the language track repositories](exercism/exercism#3240) it was stated: > Instead of SETUP.md, we're going to use exercises/TRACK_HINTS.md. exercism/DEPRECATED.trackler#17 added support for this. So it is now time to move the file.
Closes #268