Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nucleotide-codons: deprecate in favour of protein-translation #532

Merged
merged 1 commit into from
Feb 12, 2017
Merged

nucleotide-codons: deprecate in favour of protein-translation #532

merged 1 commit into from
Feb 12, 2017

Conversation

petertseng
Copy link
Member

Closes #268

@ErikSchierboom
Copy link
Member

If I look at other deprecated exercises, they almost all start with "NOTE: This exercise has been deprecated.". I like that this is the first thing you see in that case, which makes it really clear that the exercise is deprecated. Perhaps we can do that here too?

@petertseng
Copy link
Member Author

Let's try that, then. Since you didn't object to linking the issue nor the suggestion of what exercise to implement instead, I kept them, of course, just added the necessary line

@petertseng
Copy link
Member Author

petertseng commented Feb 3, 2017

Someone needs to remind me what this .deprecated file does again, whether this PR needs to be dependent on exercism/rust#258.


Okay far as I can tell from exercism/DEPRECATED.x-api#140 , deprecating it globally just prevents it from showing up in the "to be implemented" section of any other track, so I don't think exercism/rust#258 and this PR need to be temporally dependent on each other in some way.

@petertseng petertseng changed the title nucleotide-codons: deprecate for protein-translation nucleotide-codons: deprecate in favour of protein-translation Feb 3, 2017
@ErikSchierboom
Copy link
Member

I think linking to the issue and the suggestion are great features, so I'm glad you kept them in.

That means this PR can be merged, right?

@petertseng
Copy link
Member Author

That means this PR can be merged, right?

I'm ready for it to happen, and I think it is safe even while the Rust PR hasn't been merged. If we are unsure at all, we better let @kytrinyx know before the daily site deploy, in case it does cause any unexpected effects.

@ErikSchierboom
Copy link
Member

@kytrinyx would merging this PR would be safe to do?

@kytrinyx
Copy link
Member

Yes, this is safe to merge.

@petertseng petertseng merged commit d6b97a4 into exercism:master Feb 12, 2017
@petertseng petertseng deleted the nucleotide-codons branch February 12, 2017 23:05
ErikSchierboom pushed a commit that referenced this pull request Feb 17, 2017
Original deprecation in #407, for #383 and #80.
Trend of adding replacement and issue added in #532.
ErikSchierboom pushed a commit that referenced this pull request Feb 17, 2017
Original deprecation in #406, for #384 and #184.
Trend of adding replacement and issue added in #532.
emcoding pushed a commit that referenced this pull request Nov 19, 2018
In the exercism.io issue: [Deprecate the SETUP.md file in the language track
repositories](exercism/exercism#3240) it
was stated:

> Instead of SETUP.md, we're going to use exercises/TRACK_HINTS.md.

exercism/DEPRECATED.trackler#17 added support for this.

So it is now time to move the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants