Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows-installer complaining about 7.0 32 bit not being compatible. #13

Closed
rpottsoh opened this issue Jul 18, 2017 · 8 comments
Closed

Comments

@rpottsoh
Copy link
Member

On my Windows 7.0 32 bit system I am greeted with the following upon executing WinExercismSetup.exe

image

The installer terminates when OK is clicked. I am using the latest release 1.2.

@rpottsoh
Copy link
Member Author

I have forked this repo and managed to load up the project. It appears to me that the installer was targeted for x64 instead of x86.

Once I rebuilt locally for x86 the installer worked fine.

/cc: @kytrinyx , @iHiD

@kytrinyx
Copy link
Member

That's a great find. It seems like we should build two releases, then?

@rpottsoh
Copy link
Member Author

rpottsoh commented Jul 19, 2017 via email

@kytrinyx
Copy link
Member

@rpottsoh Thanks! In that case I think we just need to make a new release of the 32 bit version. I've added you to the windows-installer team, giving you commit to this repository—in case you have spare cycles to cut a release (if you don't want to be on the team feel free to remove yourself!).

@blueelvis do you have time to cut a release with this change?

@rpottsoh
Copy link
Member Author

@kytrinyx I would feel better if @blueelvis would cut the release. I consider my mod to be more of a hack that did resolve my issue, but may not be the best way to resolve the issue long term. I happen to have VS on my computer for some minor C++ coding I do at work, thus C# was available so I thought I would take a look at the Windows-Installer project to see if I could first build it (which was not a problem at all), then execute the installer from within VS to see what it might tell me. VS told me the project was built for 64 bit Windows. So it became a simple matter of looking around in VS to find a setting that controlled the target architecture of the build.... @blueelvis likely has a better, more elegant way, to control this setting.

To top it off I have never released anything on GitHub, so I would need to educate myself on the steps involved.

@kytrinyx
Copy link
Member

@rpottsoh that sounds good! I merged it for now, and if we need to do something different, we can do that in a new PR.

To top it off I have never released anything on GitHub, so I would need to educate myself on the steps involved.

I know that daunting feeling of trying to figure out the steps of something completely new. I'm exhausted just thinking about it.

Alright, I'm leaving this open for @blueelvis, and also we'll know what we can tell people if something like this comes up.

/cc @exercism/windows if anyone here feels comfortable with C# and release management, let me know and I'll add you to the team here.

@rpottsoh
Copy link
Member Author

1.2.1 published.

@kytrinyx
Copy link
Member

Thank you so much, @rpottsoh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants