Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no exercise tests are skipped when running make test #88

Closed
ghost opened this issue Oct 7, 2017 · 5 comments · Fixed by #349
Closed

Ensure no exercise tests are skipped when running make test #88

ghost opened this issue Oct 7, 2017 · 5 comments · Fixed by #349
Labels
ci ⚙️ Continuous integration related

Comments

@ghost
Copy link

ghost commented Oct 7, 2017 •
edited by ghost
Loading

Some exercise tests are skipped when running make test.

This happens as tests have been marked to be skipped using the xtest function.
Any occurrences of xtest should be replaced with xit.
@ghost ghost changed the title Ensure no tests are skipped when running make test Ensure no exercise tests are skipped when running make test Oct 7, 2017
@masters3d
Copy link
Contributor

Good catch. We also need to find it.skip and xdescribe

@masters3d
Copy link
Contributor

https://github.com/facebook/jest/blob/HEAD/packages/eslint-plugin-jest/docs/rules/no-disabled-tests.md

@ghost ghost mentioned this issue Oct 7, 2017
Merged
@ghost
Copy link
Author

ghost commented Oct 7, 2017

Added #89 for this.

Doesn't seem to be any occurrences of it.skip and xdescribe.
It looks like the usage of xtest comes from copying the ecmascript tests, so is something to keep an eye out for.

@masters3d
Copy link
Contributor

masters3d commented Oct 7, 2017 •
edited
Loading

cool. Let’s leave this open so we can update ci to catch this with a linter or similar.

@masters3d masters3d added the ci ⚙️ Continuous integration related label Dec 12, 2017
@masters3d
Copy link
Contributor

Also we should check if that all tests are ignored expect for the first one. #139

@masters3d masters3d mentioned this issue Jul 25, 2019
Merged
@SleeplessByte SleeplessByte mentioned this issue Oct 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci ⚙️ Continuous integration related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to GitHub Actions with shelljs exercism/typescript
1 participant
@masters3d