Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Tcl track #3

Closed
3 of 6 tasks
sshine opened this issue Dec 11, 2018 · 6 comments
Closed
3 of 6 tasks

Bootstrap Tcl track #3

sshine opened this issue Dec 11, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@sshine
Copy link
Contributor

sshine commented Dec 11, 2018

  • Update docs: Initial docs #4
  • Implement Hello World: hello-world: Create exercise #5
  • CI for checking validity of example
  • Set up commit hook and policy for PR-driven development
  • Find json library for extracting canonical data for exercises
  • Build test generator
@sshine sshine mentioned this issue Apr 4, 2019
@sshine
Copy link
Contributor Author

sshine commented Apr 4, 2019

Going over the checklist:

@sshine
Copy link
Contributor Author

sshine commented Apr 4, 2019

@sshine
Copy link
Contributor Author

sshine commented Apr 8, 2019

Idea by @sebres for making single-file testing fail fast:

proc test args {
    upvar ::tcltest::numTests numTests
    set numTestsFailed $numTests(Failed)
    uplevel [list ::tcltest::test {*}$args]
    if {$numTests(Failed) > $numTestsFailed} {
        puts "*** EXIT ON ERROR ***"
        exit 1
    }
}

Updated: Fixed nt -> numTests in all places. :-)

@sebres
Copy link

sebres commented Apr 8, 2019

well, initially I wrote:

-    upvar ::tcltest::numTests numTests
+    upvar ::tcltest::numTests nt

so either rename nt var everywhere (or apply fix above;)

@sshine
Copy link
Contributor Author

sshine commented Apr 9, 2019

Thanks. :-) I'll save your second suggestion here as well:

trace add variable ::tcltest::numTests(Failed) write {
    apply {args {
        puts {*** EXIT ON ERROR ***}
        exit 1
    }}
}

@sshine sshine self-assigned this Aug 6, 2019
@sshine sshine added the enhancement New feature or request label Aug 6, 2019
@sshine
Copy link
Contributor Author

sshine commented Jan 14, 2020

Closing this issue, since the Tcl track has been bootstrapped without test generators so far.

@sshine sshine closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants