Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-Fer starts with a file that already satisfies all tests #1266

Closed
wischi-chr opened this issue May 21, 2021 · 6 comments · Fixed by #1267
Closed

Two-Fer starts with a file that already satisfies all tests #1266

wischi-chr opened this issue May 21, 2021 · 6 comments · Fixed by #1267

Comments

@wischi-chr
Copy link

I'm not sure if this is a problem with the exercise, v3 or even not a bug at all.

https://exercism.lol/tracks/rust/exercises/two-fer/edit
https://github.com/exercism/rust/tree/main/exercises/practice/two-fer

After starting the exercise there is basically nothing left to do besides pressing F2 ("run tests")

@ErikSchierboom
Copy link
Member

@wischi-chr It looks like the stub file contains the correct implementation: https://github.com/exercism/rust/blob/main/exercises/practice/two-fer/src/lib.rs This is not really an issue with the itself, but with the Rust track itself. I'm therefore moving this issue to the exercism/rust repository.

@ErikSchierboom ErikSchierboom transferred this issue from exercism/v3-beta May 22, 2021
@ErikSchierboom ErikSchierboom changed the title [Page: Editor] [Rust] Two-Fer starts with a file that already satisfies all tests Two-Fer starts with a file that already satisfies all tests May 22, 2021
@coriolinus
Copy link
Member

Two-fer is deprecated and should not be visible in the v3 website:

rust/config.json

Lines 1419 to 1431 in 519032f

{
"slug": "two-fer",
"name": "Two Fer",
"uuid": "585e963b-366c-48bc-b523-29b6be4175c8",
"practices": [],
"prerequisites": [],
"difficulty": 1,
"topics": [
"match",
"strings"
],
"status": "deprecated"
}

There was a problem, years ago, which broke things if we removed it entirely, so deprecation was the best we could do.

@ErikSchierboom
Copy link
Member

I think it will be visible to students that started the exercise when it was still not deprecated, right @iHiD?

@iHiD
Copy link
Member

iHiD commented May 22, 2021

It will. That's not really a problem in itself as the nature of having starting it means they'll probably have a solution. However, because we have the "reset exercise" functionality in v3, where a student can go back to the start of an exercise if they get stuck, this does become important.

@coriolinus Is there an old stub we can revert to? Or if not, we should probably just make this stub an empty file.

@coriolinus
Copy link
Member

Previous discussion: #832.

I note that the exercise has been deprecated for over two years. It seems unlikely to me that any student has opened but not completed that exercise in that span.

See also: #773 (comment), #564, #547, #552.

@iHiD
Copy link
Member

iHiD commented May 22, 2021

As there are 22 people in that group, I've opened #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants