Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Luhn tests #533

Closed
IanWhitney opened this issue Jan 11, 2017 · 11 comments
Closed

Changes to Luhn tests #533

IanWhitney opened this issue Jan 11, 2017 · 11 comments

Comments

@IanWhitney
Copy link

We recently rewrote the test suite for the Luhn exercise. Since this track implements Luhn, please take a look at the new canonical_data.json file and see if your track should update its implementation or tests.

Details on the test changes and the motivation can be found in the PR.

Tracking of these changes is being done at the tracking issue.

@kotp
Copy link
Member

kotp commented Jan 11, 2017

Now is a good time to do a generator for this exercise/test as well.

@morrme
Copy link

morrme commented Apr 6, 2017

@IanWhitney @kotp is there anything that needs to be done for this track?

@kotp
Copy link
Member

kotp commented Apr 7, 2017

@morme Yes.

Look through the issues and if you see something you are interested in, let me know. I do monitor the Exercism gitter rooms, and contacting me for Ruby in the ruby gitter room is a good place to do so if you do have questions specifically, or if you would like to have some help setting up and working on an issue.

If you are interested in working on this one specifically, there are two directions that this can go. Either match up the current tests with the canonical_data file mentioned in the description above, or work on creating a generator library for this exercise specifically.

The generator is the long term preferred solution.

@morrme
Copy link

morrme commented Apr 7, 2017

@kotp i'd like to know more about the generator option.

@kotp
Copy link
Member

kotp commented Apr 7, 2017

This document is a good place to start. You can also look at the lib/ folder to see the exercises that are already generated, and compare them for examples.

@hilary hilary mentioned this issue Apr 21, 2017
10 tasks
@kotp kotp closed this as completed Apr 21, 2017
@kotp
Copy link
Member

kotp commented Apr 21, 2017

Thanks @hilary !!

@kotp
Copy link
Member

kotp commented Apr 21, 2017

Thanks @morme for considering to work on this as well. Hopefully I have not missed your contribution.

@morrme
Copy link

morrme commented Apr 21, 2017

@kotp this was one i fought with a little. i still want to get this workflow down, because it would be good to do it on other exercises.

@hilary
Copy link
Contributor

hilary commented Apr 21, 2017

@morrme We updated the documentation for the generators; it was a bit ... obscure :D

@morrme
Copy link

morrme commented Apr 21, 2017

@hilary i blamed my inexperience. good to know!

@Insti
Copy link
Contributor

Insti commented Apr 22, 2017

Definitely not your fault @morrme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants