Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify correct line counts #66

Closed
ErikSchierboom opened this issue Aug 18, 2022 · 5 comments
Closed

Identify correct line counts #66

ErikSchierboom opened this issue Aug 18, 2022 · 5 comments

Comments

@ErikSchierboom
Copy link
Member

To count lines of student's solution, we use the tokei library, which unfortunately doesn't support red at the moment: https://github.com/XAMPPRocky/tokei#supported-languages

Luckily, adding a language should not be that hard: https://github.com/XAMPPRocky/tokei/blob/master/CONTRIBUTING.md
Fun fact: the recently launched unison track did this: XAMPPRocky/tokei#920

Once the PR has been merged, let me know, as I'll need to redeploy the line counter afterwards.

@loziniak
Copy link
Member

Just submitted a PR: XAMPPRocky/tokei#958
Do I need to change anything on Exercism side, or just wait for merge on tokei?

@loziniak
Copy link
Member

All tests OK on tokei, waiting for merge and release :-)

@ErikSchierboom
Copy link
Member Author

@loziniak Ping me when the pr is merged

@BNAndras
Copy link
Member

BNAndras commented Feb 2, 2024

Exercism has its own tokei fork now at https://github.com/exercism/tokei so we should make a PR there instead to resolve this issue.

@loziniak
Copy link
Member

loziniak commented Feb 3, 2024

Created a pull-request on Exercism's Tokei repo: exercism/tokei#12 .

@BNAndras BNAndras closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants