Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept Conditionals Add Files #2430

Merged
merged 9 commits into from
May 30, 2021

Conversation

BethanyG
Copy link
Member

Filled in docs for the conditionals concept.

  • Added introduction.md
  • Added about.md
  • Added links.json
  • Added blurb in .meta/config.json
  • Added authors in .meta/config.json

@BethanyG BethanyG requested a review from a team as a code owner May 15, 2021 00:04
@BethanyG BethanyG requested a review from cmccandless May 21, 2021 00:25
@BethanyG BethanyG requested review from a team and removed request for cmccandless May 28, 2021 16:56
Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left some comments re: wording/grammar

concepts/conditionals/about.md Outdated Show resolved Hide resolved
concepts/conditionals/about.md Outdated Show resolved Hide resolved
concepts/conditionals/about.md Outdated Show resolved Hide resolved
concepts/conditionals/about.md Outdated Show resolved Hide resolved
concepts/conditionals/about.md Outdated Show resolved Hide resolved
concepts/conditionals/about.md Show resolved Hide resolved
concepts/conditionals/about.md Show resolved Hide resolved
concepts/conditionals/about.md Show resolved Hide resolved
concepts/conditionals/introduction.md Outdated Show resolved Hide resolved
Applied suggestions/edits/corrections from code review.

Co-authored-by: Tim Austin <[email protected]>
@BethanyG
Copy link
Member Author

Squashing this one to avoid a hairy merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation 💖 specific improvements to documentation on the track, the exercises, or the repo. x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants