-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo elyses-enchantments/lists.py as card-games #2405
Conversation
Please see #2404, (which should be merged first or combined with this rename) for the associated |
@cmccandless - tagging you because I extensively helped with the story on this, so I think it needs a different set of eyes. 😄 |
@IsaacG -- if @cmccandless has no additional comments, I think this is good to go! 🎉 thank you for your work on it. I am, however going to wait to merge-- because we've renamed the exercise from what it was originally, we'll probably need @iHiD help with syncing. And since there are at least three more exercises that need rewrite/rename, I think we'll want to do them in a batch to avoid problems. |
Approved |
If these are renamed concept exercises, it should be fine to merge. Things should automatically sync up. Thanks for checking though, and if it doesn't tell us so we can fix the bug :) |
Urg. @cmccandless - I think I need your |
I'm going to try rebasing onto our main branch |
I'll make a bookmark branch just in case to preserve the work here as it is now |
I think we're good to go. @IsaacG ? Spot anything in need of correcting?? |
Looks about right to me! |
Rewrite the lists concepts exercise