Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary: improve tests for invalid numbers #329

Closed
kytrinyx opened this issue Apr 7, 2016 · 4 comments
Closed

binary: improve tests for invalid numbers #329

kytrinyx opened this issue Apr 7, 2016 · 4 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 7, 2016

We should have separate tests for:

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number
  • invalid digits (e.g. 2)

If the test suite for binary has test cases that cover these edge cases, this issue can safely be closed.

See exercism/problem-specifications#95

@behrtam
Copy link
Contributor

behrtam commented Apr 7, 2016

The current status looks like this ...

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number
  • invalid digits (e.g. 2)

So, we only need to add the case "10convert01" as suggested by @odeits.

Edit: Looks like we added those with #274 because of exercism/problem-specifications#95. So we need to clarify if we need all 3 test cases (binary numbers at start, end and both) and create a .json file in x-common.

@kytrinyx
Copy link
Member Author

kytrinyx commented Apr 7, 2016

and create a .json file in x-common

Yeah, absolutely.

@arcuru
Copy link
Contributor

arcuru commented Jul 12, 2016

Since binary is in the process of being deprecated (exercism/problem-specifications#279) this issue can probably be closed.

@kytrinyx
Copy link
Member Author

Yeah, I think you're right about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants