-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binary: improve tests for invalid numbers #329
Comments
The current status looks like this ...
So, we only need to add the case "10convert01" as suggested by @odeits. Edit: Looks like we added those with #274 because of exercism/problem-specifications#95. So we need to clarify if we need all 3 test cases (binary numbers at start, end and both) and create a |
Yeah, absolutely. |
Since binary is in the process of being deprecated (exercism/problem-specifications#279) this issue can probably be closed. |
Yeah, I think you're right about that. |
We should have separate tests for:
If the test suite for binary has test cases that cover these edge cases, this issue can safely be closed.
See exercism/problem-specifications#95
The text was updated successfully, but these errors were encountered: