Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-square: Remove test of intermediate functions #750

Closed
behrtam opened this issue Apr 7, 2017 · 4 comments
Closed

crypto-square: Remove test of intermediate functions #750

behrtam opened this issue Apr 7, 2017 · 4 comments

Comments

@behrtam
Copy link
Contributor

behrtam commented Apr 7, 2017

So, I was just looking at the canonical test data for crypto-square and I think it was the first time I saw test data for an exercise that also tested the intermediate steps of the problem like normalization or concatenation of segments.

Shouldn't those intermediate tests be removed, as it was agreed on in: exercism/discussions#41

They originated from this PR: #250

@Insti
Copy link
Contributor

Insti commented Apr 25, 2017

Link to canonical-data.json

@petertseng
Copy link
Member

Indeed, the Haskell track discussed in exercism/haskell#259 and decided not to test intermediate functions, diverging from x-common in exercism/haskell#391.

Not saying that all have to take the exact approach the Haskell track took or that any other track should agree with the exact same reasons, but if this data helps make the decision, we are glad to provide it.

@petertseng
Copy link
Member

Since crypto-square's introduction into the Go track at exercism/go#68 the Go track has never tested the intermediate functions. So if x-common goes this route, xgo would become closer to x-common.

@nholden
Copy link

nholden commented Oct 7, 2017

#922 was merged, so I think we can close out this issue.

@stkent stkent closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants