From f8abfb372a1cb664ab52ce9c67fa526b050a3d30 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sun, 5 Nov 2023 17:19:10 +0100 Subject: [PATCH 1/3] Fix typo in exercise name --- config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.json b/config.json index 9f994801..f9cc19a4 100644 --- a/config.json +++ b/config.json @@ -38,7 +38,7 @@ { "uuid": "d6b00994-36b1-4d2c-9a7f-d55f3cbdf4de", "slug": "sweethearts", - "name": "Highschool Sweetheats", + "name": "Highschool Sweethearts", "prerequisites": ["basic-syntax"], "concepts": ["strings"], "status": "beta" From 4c754b9b13c8f203609fde2180637fa2413922d3 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sun, 5 Nov 2023 17:28:07 +0100 Subject: [PATCH 2/3] Add missing trim() test --- .../concept/sweethearts/HighSchoolSweetheartTest.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/exercises/concept/sweethearts/HighSchoolSweetheartTest.php b/exercises/concept/sweethearts/HighSchoolSweetheartTest.php index 31216f6a..e71e11eb 100644 --- a/exercises/concept/sweethearts/HighSchoolSweetheartTest.php +++ b/exercises/concept/sweethearts/HighSchoolSweetheartTest.php @@ -27,6 +27,16 @@ public function testFirstLetterDoesNotChangeCase() $this->assertEquals('j', $sweetheart->firstLetter('jane')); } + /** + * @testdox getting the first letter removes whitespace from the name + * @task_id 1 + */ + public function testFirstLetterRemovesWhitespace() + { + $sweetheart = new HighSchoolSweetheart(); + $this->assertEquals('J', $sweetheart->firstLetter(' Jane')); + } + /** * @testdox gets the first letter and appends a dot * @task_id 2 From 35b791aa1f31f55b5c05bc9d5fba54bea6106340 Mon Sep 17 00:00:00 2001 From: Michael Kramer Date: Sun, 5 Nov 2023 17:38:53 +0100 Subject: [PATCH 3/3] Fix PHP version setting for GitHub actions --- .github/workflows/exercise-tests-phpunit-9.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/exercise-tests-phpunit-9.yml b/.github/workflows/exercise-tests-phpunit-9.yml index e9dc6a47..0c6c1632 100644 --- a/.github/workflows/exercise-tests-phpunit-9.yml +++ b/.github/workflows/exercise-tests-phpunit-9.yml @@ -29,7 +29,7 @@ jobs: - uses: shivammathur/setup-php@81cd5ae0920b34eef300e1775313071038a53429 with: - version: ${{ matrix.php-version }} + php-version: ${{ matrix.php-version }} extensions: gmp - name: Install dependencies