Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit broken Unit Tests on MacOS but failed silently #859

Closed
tomasnorre opened this issue Nov 14, 2024 · 2 comments · Fixed by #861
Closed

Commit broken Unit Tests on MacOS but failed silently #859

tomasnorre opened this issue Nov 14, 2024 · 2 comments · Fixed by #861
Assignees
Labels

Comments

@tomasnorre
Copy link
Contributor

tomasnorre commented Nov 14, 2024

This commit 1df6486 broken the unit tests on MacOS, but fails silently, so I saw it by coincidence.

Will focus on this before adding more PRs for the Sync Exercises.

Screenshot From 2024-11-14 19-06-06

@tomasnorre tomasnorre self-assigned this Nov 14, 2024
@tomasnorre tomasnorre added the bug label Nov 14, 2024
@mk-mxp
Copy link
Contributor

mk-mxp commented Nov 15, 2024

Maybe add local -a name_filter before name_filter=()? This makes the variable name a) local scoped and b) known as an array even when not filled. If that doesn't help, replace name_filter=() with name_filter=( " " ) # MacOS otherwise sees unbound variable or similar.

@tomasnorre
Copy link
Contributor Author

Maybe add local -a name_filter before name_filter=()? This makes the variable name a) local scoped and b) known as an array even when not filled. If that doesn't help, replace name_filter=() with name_filter=( " " ) # MacOS otherwise sees unbound variable or similar.

Will check it out later. I have an older macbook, that I might be able to test it on locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants